Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [el-dialog] remove width validator (#5329) #5568

Merged

Conversation

purepear
Copy link
Contributor

@purepear purepear commented Jan 23, 2022

ElDialog is the only place that isValidWidthUnit is used and it is somewhat restrictive in terms of valid css width values. Because there are many possible non-"number + unit" ways to set the width i think it's better to just remove the validator instead of checking for things like min(...), max(...), clamp(...), calc(...), min-content, max-content, fit-content(...), auto, inherit, initial, etc.

If people think it's better to keep the validator but validate agains all possible css width values just let me know and i'll try to do that instead.

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Jan 23, 2022

@sxzz
Copy link
Collaborator

sxzz commented Jan 23, 2022

/cc @element-plus/backers

@sxzz sxzz merged commit 5286713 into element-plus:dev Jan 23, 2022
@element-bot element-bot mentioned this pull request Jan 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants