Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): work around #6378 #6380

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

CarterLi
Copy link
Contributor

@CarterLi CarterLi commented Mar 2, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Although this solution is not perfect, it did resolve my problem

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

@jw-foss
Copy link
Member

jw-foss commented Mar 2, 2022

@CarterLi 感谢修复这个问题,这个可能是 popper-content 用的 slot 组件的 bug, 我们可以先用这个 workaround 🙏

@jw-foss
Copy link
Member

jw-foss commented Mar 2, 2022

你可否在修改的地方加一个注释,然后链接到你提的 issue 里去,后面方便知道上下文 🙇

@CarterLi
Copy link
Contributor Author

CarterLi commented Mar 2, 2022

你可否在修改的地方加一个注释,然后链接到你提的 issue 里去,后面方便知道上下文 🙇

好了

苦逼程序员解这个bug搞到现在还没下班,正在尝试改 node_modules 文件的方法把这个patch打进去

@jw-foss
Copy link
Member

jw-foss commented Mar 2, 2022

@CarterLi 实在抱歉。。 周五会发个版。

@CarterLi
Copy link
Contributor Author

CarterLi commented Mar 2, 2022

有bug很正常,我们的代码也有bug。

感谢修复这个问题,这个可能是 popper-content 用的 slot 组件的 bug, 我们可以先用这个 workaround

也有可能是vue的bug。如果把 destroyed 加到 el-popper-content 上面就会报 vue 的内部错误

@jw-foss jw-foss merged commit 8a80bfe into element-plus:dev Mar 2, 2022
@element-bot element-bot mentioned this pull request Mar 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants