Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(components): [select] click icon twice #6471

Merged
merged 1 commit into from
Mar 10, 2022
Merged

test(components): [select] click icon twice #6471

merged 1 commit into from
Mar 10, 2022

Conversation

Alanscut
Copy link
Contributor

@Alanscut Alanscut commented Mar 7, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited

@Alanscut Alanscut requested a review from jw-foss March 7, 2022 11:05
jw-foss
jw-foss reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alanscut Left a comment for you to consider ;)

packages/components/select/__tests__/select.spec.ts Show resolved Hide resolved
@Alanscut Alanscut force-pushed the test_select-click-icon-twice branch from 734915e to d68eb94 Compare March 8, 2022 06:42
@Alanscut
Copy link
Contributor Author

Alanscut commented Mar 8, 2022

@JeremyWuuuuu done

@jw-foss jw-foss merged commit 73e60cd into element-plus:dev Mar 10, 2022
@element-bot element-bot mentioned this pull request Mar 10, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alanscut @jw-foss