fix(components): [upload] fileList prop should sync uploadFiles #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
got time to review this? @emojiiii |
|
Could you please provide a minimum reproduction link? |
jw-foss
added
Contribution::Community
1st contribution
sxzz
approved these changes
Mar 10, 2022
|
PTAL @JeremyWuuuuu |
jw-foss
approved these changes
Mar 10, 2022
|
sorry, just saw the replys. Thank you |
exherb
commented
Mar 10, 2022
| file.status ||= 'success' | ||
| } | ||
| uploadFiles.value = fileList as UploadFiles |
There was a problem hiding this comment.
- Force type is not a good idea
- Why watch deep? The main usage case is restore previous uploaded files from api returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.https://togithub.com/element-plus/element-plus/issues/6014 removed this sync logic, any reason?