Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: selet-v2 value-key mode selected style and onClonse bug #6602

Merged
merged 2 commits into from
Mar 15, 2022
Merged

fix: selet-v2 value-key mode selected style and onClonse bug #6602

merged 2 commits into from
Mar 15, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Mar 13, 2022 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

Hello @chenxch, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Mar 13, 2022 •
edited

@chenxch
Copy link
Member Author

chenxch commented Mar 13, 2022

fix: #6502
image

@chenxch
Copy link
Member Author

chenxch commented Mar 13, 2022

在处理selected样式的时候发现target出现类似label in value的情况，不知道是原先设计如此还是中间环境出现问题

@jw-foss
Copy link
Member

jw-foss commented Mar 14, 2022

@chenxch Please run yarn format to format the code properly.

@jw-foss jw-foss added the 1st contribution Their very first contribution label Mar 14, 2022
@jw-foss jw-foss requested a review from a team March 14, 2022 11:59
@chenxch
Copy link
Member Author

chenxch commented Mar 14, 2022

@chenxch Please run yarn format to format the code properly.
@JeremyWuuuuu processed.

@jw-foss jw-foss merged commit dba6a63 into element-plus:dev Mar 15, 2022
@element-bot element-bot mentioned this pull request Mar 15, 2022
Merged
3 tasks
@chenxch chenxch deleted the fix/select-v2_issue-6502 branch April 23, 2022 10:30
@Karolis-Stoncius
Copy link
Contributor

Could this be fixed in the simple select as well?

@chenxch
Copy link
Member Author

chenxch commented Aug 11, 2022

Could this be fixed in the simple select as well?

I'll take a look at it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

Assignees
No one assigned
Labels
1st contribution Their very first contribution Contribution::Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenxch @jw-foss @Karolis-Stoncius @xiaochenchen-igg-com