Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [dropdown] fix #8311 #8338

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(components): [dropdown] fix #8311 #8338

wants to merge 1 commit into from

Commits on Jun 18, 2022

  1. fix(components): [dropdown] fix element-plus#8311 

    * dropdown/src/content.vue: `triggeringElementRef` is a reference of
`el-button` component, not the `button` dom object. We should get its
dom object before passing it to `virtual-ref`.
* popper/src/content.vue: `referenceEl` is `triggeringElementRef`, which
is a dom object. Because both dom object and its instance function
`getBoundingClientRect` are not reactive, watching their changes are of
non-sence.

It's strange that it worked before v2.2.6, don't know what happened
    @CarterLi
    CarterLi committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    f7b13b2 View commit details
    Browse the repository at this point in the history