fix(components): [message] fix overlapping issue #8368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Banana-energy, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
Hello @Banana-energy, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=8368 |
sxzz
reviewed
Jun 20, 2022
| @@ -61,7 +61,7 @@ const message: MessageFn & Partial<Message> & { _context: AppContext | null } = | |||
|
|
|||
| let verticalOffset = options.offset || 20 | |||
| instances.forEach(({ vm }) => { | |||
| verticalOffset += (vm.el?.offsetHeight || 0) + 16 | |||
There was a problem hiding this comment.
Actually the problem is that vm.el?.offsetHeight is 0.
sxzz
added a commit
that referenced
this pull request
Jun 20, 2022
3 tasks
sxzz
added a commit
that referenced
this pull request
Jun 20, 2022
sxzz
added a commit
that referenced
this pull request
Jun 21, 2022
sxzz
added a commit
that referenced
this pull request
Jun 21, 2022
sxzz
added a commit
that referenced
this pull request
Jun 21, 2022
sxzz
added a commit
that referenced
this pull request
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.closes #7217