Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table] table-column expand nested table wrong style #8522

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix(components): [table] table-column expand nested table wrong style #8522

merged 2 commits into from
Jul 4, 2022

Conversation

liunnn1994
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Fixed #8521

Snipaste_2022-06-28_18-55-50
Snipaste_2022-06-28_18-56-05
Snipaste_2022-06-28_18-56-15
Snipaste_2022-06-28_18-56-32

@pull-request-triage
Copy link

👋 @asdjgfr, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited

@github-actions
Copy link

Hello @asdjgfr, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@btea btea requested a review from YunYouJun June 28, 2022 13:19
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8522
Please comment the example via this playground if needed.

@liunnn1994
Copy link
Contributor Author

🧪 Playground Preview: https://element-plus.run/?pr=8522 Please comment the example via this playground if needed.

Couldn't save in https://element-plus.run/?pr=8522. Add example in https://element-plus.run.

@liunnn1994
Copy link
Contributor Author

@YunYouJun @sxzz Shall we merge this PR? This error cause something wrong in my project, THX.

@sxzz sxzz changed the title Fixed #8521 table-column expand nested table show wrong style fix(components): [table] table-column expand nested table wrong style Jul 1, 2022
@liunnn1994
Copy link
Contributor Author

@YunYouJun Already removed !mportant, shall we merge? THX.

@YunYouJun
Copy link
Member

YunYouJun commented Jul 4, 2022 •
edited

Good job.

One last tip, can you add your example to the documentation?
Or modify an existing example to make it easier for users to preview.

Just like what you wriitten in playground

@liunnn1994
Copy link
Contributor Author

Good job.

One last tip, can you add your example to the documentation? Or modify an existing example to make it easier for users to preview.

Just like what you wriitten in playground

@YunYouJun I modified Expandable row part. Add switch button and update data from Tom_and_Jerry 😋.

@YunYouJun YunYouJun merged commit 63c038a into element-plus:dev Jul 4, 2022
@element-bot element-bot mentioned this pull request Jul 8, 2022
Merged
3 tasks
@liunnn1994 liunnn1994 mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunYouJun YunYouJun YunYouJun approved these changes

Assignees

@liunnn1994 liunnn1994

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [table] When table-column expand nested table show wrong style
2 participants
@liunnn1994 @YunYouJun