Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [popper] fix type error #8529

Merged
merged 6 commits into from
Sep 22, 2022
Merged

refactor(components): [popper] fix type error #8529

merged 6 commits into from
Sep 22, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jun 29, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8529
Please comment the example via this playground if needed.

@holazz holazz mentioned this pull request Jul 2, 2022
Merged
3 tasks
@tolking tolking requested review from jw-foss and sxzz July 3, 2022 09:37
@holazz
Copy link
Member Author

holazz commented Jul 3, 2022

@tolking updated, please review again.

@holazz holazz mentioned this pull request Aug 26, 2022
Merged
jw-foss
jw-foss reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holazz in general the changes LGTM, I left a non-blocking comment for you to consider, back to you 🏓

packages/components/popper/src/content.vue Outdated Show resolved Hide resolved
@holazz
chore: extract createPopperInstance param type
60ee11f 
Co-authored-by: lizhequ <lizhequ@ysbang.cn>
@sxzz sxzz enabled auto-merge (squash) September 22, 2022 01:14
@sxzz sxzz merged commit d730161 into element-plus:dev Sep 22, 2022
@holazz holazz deleted the refactor/popper_type branch September 22, 2022 01:33
@element-bot element-bot mentioned this pull request Oct 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss left review comments

@tolking tolking tolking left review comments

@sxzz sxzz sxzz approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holazz @sxzz @jw-foss @tolking