-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [dropdown] fix visible-change event delay trigger #8601 #8602
Conversation
👋 @shooterRao, seems like this is your first time contribution to element-plus.
|
Hello @shooterRao, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=8602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
cc @element-plus/backers Need to double check if there are other effects. |
It seems that this PR broke the original A11y. Use the Need to handle focus in the show event to make sure the internal DOM has been generated. |
@shooterRao Can you work with @tolking to fix the problem? |
In fact, we should talk about |
use |
ok, I will fix this problem tomorrow.😀 @tolking @YunYouJun @chenxch |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.