Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [dropdown] fix visible-change event delay trigger #8601 #8602

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

shooterRao
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @shooterRao, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

Hello @shooterRao, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8602
Please comment the example via this playground if needed.

@chenxch chenxch self-requested a review July 3, 2022 09:21
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@chenxch
Copy link
Member

chenxch commented Jul 3, 2022

cc @element-plus/backers Need to double check if there are other effects.

@chenxch chenxch merged commit 2486d92 into element-plus:dev Jul 4, 2022
@tolking
Copy link
Member

tolking commented Jul 5, 2022

It seems that this PR broke the original A11y.

Use the before-show will not move focus into content.

Need to handle focus in the show event to make sure the internal DOM has been generated.

@YunYouJun
Copy link
Member

@shooterRao Can you work with @tolking to fix the problem?

@chenxch
Copy link
Member

chenxch commented Jul 5, 2022

In fact, we should talk about handleShowTooltip split into handleBeforeShowTooltip, handleBeforeShowTooltip is responsible for emit visible-change.

@chenxch
Copy link
Member

chenxch commented Jul 5, 2022

use before-showshowbefore-hide

@shooterRao
Copy link
Contributor Author

shooterRao commented Jul 5, 2022

ok, I will fix this problem tomorrow.😀 @tolking @YunYouJun @chenxch

@element-bot element-bot mentioned this pull request Jul 8, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants