Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(directives): drop resize #8617

Merged
merged 1 commit into from Jul 22, 2022
Merged

refactor(directives): drop resize #8617

merged 1 commit into from Jul 22, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jul 4, 2022 •
edited

#6114

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@holazz holazz mentioned this pull request Jul 19, 2022
Closed
3 tasks
@holazz holazz force-pushed the refactor/directives_resize branch from 0f3f2ae to d8c0f98 Compare July 21, 2022 09:53
@holazz holazz marked this pull request as ready for review July 21, 2022 09:55
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8617
Please comment the example via this playground if needed.

@sxzz sxzz merged commit 89a57af into element-plus:dev Jul 22, 2022
@holazz holazz deleted the refactor/directives_resize branch July 22, 2022 02:22
@element-bot element-bot mentioned this pull request Jul 22, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holazz @sxzz