Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [tree] fix setCurrentKey setCurrentNode emit #8881

Merged
merged 2 commits into from Sep 1, 2022

Conversation

gjfei
Copy link
Contributor

@gjfei gjfei commented Jul 19, 2022

Please make sure these boxes are checked before submitting your PR, thank you!
fix #8855

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @gjfei, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @gjfei, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

@gjfei gjfei changed the title fix(components): [tree] fix setCurrentKey setCurrentNode emit event (… fix(components): [tree] fix setCurrentKey setCurrentNode emit (8855) Jul 19, 2022
@github-actions github-actions bot added the CommitMessage::Unqualified Unqualified commit message label Jul 19, 2022
@github-actions github-actions bot added CommitMessage::Qualified Qualified commit message and removed CommitMessage::Unqualified Unqualified commit message labels Jul 19, 2022
@github-actions
Copy link

github-actions bot commented Jul 19, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8881
Please comment the example via this playground if needed.

Copy link
Member

@holazz holazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left a few comments for your consideration.

packages/components/tree/src/tree.vue Outdated Show resolved Hide resolved
@holazz
Copy link
Member

holazz commented Jul 19, 2022

One more suggestion, you can add a keyword before the issues link in the description, such as fix, close, etc., and no need to link issues in the title.

@gjfei
Copy link
Contributor Author

gjfei commented Jul 19, 2022

还有一个建议,可以在description的issues链接前加一个关键词,比如fix、close,标题中不需要链接issues。

好的

@gjfei gjfei changed the title fix(components): [tree] fix setCurrentKey setCurrentNode emit (8855) fix(components): [tree] fix setCurrentKey setCurrentNode emit Jul 19, 2022
@gjfei
Copy link
Contributor Author

gjfei commented Aug 16, 2022

@iamkun 现在都没人处理这些pr 了?

@holazz
Copy link
Member

holazz commented Aug 16, 2022

@iamkun 现在都没人处理这些pr 了?

我也有一些打开了好久的 PR,可能团队成员不都是全职在维护这个项目吧 🤔

@gjfei
Copy link
Contributor Author

gjfei commented Aug 16, 2022

@iamkun 现在都没人处理这些pr 了?

我也有一些打开了好久的 PR,可能团队成员不都是全职在维护这个项目吧 🤔

我已经有点受不了,既然不打算维护了,就把权限给到一些愿意维护的人,这样算啥事情

@holazz
Copy link
Member

holazz commented Aug 16, 2022

@iamkun 现在都没人处理这些pr 了?

我也有一些打开了好久的 PR,可能团队成员不都是全职在维护这个项目吧 🤔

我已经有点受不了,既然不打算维护了,就把权限给到一些愿意维护的人,这样算啥事情

PR 应该都是要经过多个人审查通过后才可以合并,所以会慢些,别着急

@xiaoxian521 xiaoxian521 merged commit 8b96cb1 into element-plus:dev Sep 1, 2022
@element-bot element-bot mentioned this pull request Sep 2, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [tree] 调用setCurrentKey方法后,没有触发 current-change 事件
3 participants