Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [dialog] should emit open event after nextTick #9209

Merged
merged 2 commits into from
Aug 16, 2022
Merged

fix(components): [dialog] should emit open event after nextTick #9209

merged 2 commits into from
Aug 16, 2022

Conversation

buqiyuan
Copy link
Member

@buqiyuan buqiyuan commented Aug 4, 2022

Please make sure these boxes are checked before submitting your PR, thank you!
fix: #9197

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9209
Please comment the example via this playground if needed.

@buqiyuan buqiyuan merged commit 6aa151f into dev Aug 16, 2022
@buqiyuan buqiyuan deleted the fix/dialog_emit_open branch August 16, 2022 14:04
@element-bot element-bot mentioned this pull request Aug 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@buqiyuan buqiyuan

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
3 participants
@buqiyuan @btea @ryuhangyeong