Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] support dynamic value for option #9220

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(components): [select] support dynamic value for option #9220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/select/src/option.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ export default defineComponent({
const { visible, hover } = toRefs(states)

const vm = getCurrentInstance().proxy
const key = (vm as unknown as SelectOptionProxy).value

select.onOptionCreate(vm as unknown as SelectOptionProxy)

onBeforeUnmount(() => {
const key = (vm as unknown as SelectOptionProxy).value
const { selected } = select
const selectedOptions = select.props.multiple ? selected : [selected]
const doesSelected = selectedOptions.some((item) => {
Expand Down
6 changes: 6 additions & 0 deletions packages/components/select/src/useOption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ export function useOption(props, states) {
() => props.value,
(val, oldVal) => {
const { remote, valueKey } = select.props

if (!Object.is(val, oldVal)) {
select.onOptionDestroy(oldVal, instance.proxy)
select.onOptionCreate(instance.proxy)
}

if (!props.created && !remote) {
if (
valueKey &&
Expand Down