Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(components): [virtual-list] RTLOffsetType compare #9320

Merged
merged 1 commit into from
Aug 18, 2022
Merged

perf(components): [virtual-list] RTLOffsetType compare #9320

merged 1 commit into from
Aug 18, 2022

Conversation

alwynou
Copy link
Contributor

@alwynou alwynou commented Aug 14, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @alwynou, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 14, 2022
@github-actions
Copy link

github-actions bot commented Aug 14, 2022 •
edited

@github-actions
Copy link

Hello @alwynou, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=9320
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented Aug 18, 2022

Thank you for your contribution ❤

@btea btea merged commit 54f4353 into element-plus:dev Aug 18, 2022
@element-bot element-bot mentioned this pull request Aug 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@alwynou alwynou

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alwynou @btea @ryuhangyeong