Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icon): reduce getter access. #9360

Merged
merged 2 commits into from Aug 30, 2022
Merged

Conversation

zhangenming
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @zhangenming, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 18, 2022
@github-actions
Copy link

Hello @zhangenming, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 18, 2022

@github-actions github-actions bot added the CommitMessage::Unqualified Unqualified commit message label Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2022

Hello, @, seems like your commit message contains some issues.

你好,@,你的提交消息不符合 Element Plus 的提交消息规范。

⧗   input: Update icon.vue
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: Update icon.vue
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint


Please refer to Commit Example for fixing it.

请参考 提交示例 来修改你的提交消息。

Note that all your commits will be squashed into one for being linted, so you might need to revision your commits.
If you do not know how to do so, please refer to Keeping git commit history clean to update your commit message.

你的所有 commit(s) 会被合并为一个 commit 来被验证,所以你可能需要修改你之前的 commit(s) 消息。
如果你不知道如何来修改之前已经提交的记录,请参考让你的 Git 提交历史保持干净来修改。

If you find it hard to do it by yourself, run command below to use an intuitive tool for that.

如果你觉得自己写这个提交消息很难,请使用下面的命令来启动一个交互式工具来帮助你生成消息。

pnpm cz

Note that if you do not fix the commit message issue, your PR will be automatically closed within 3 days.

请注意,如果你没有按照规范修改你的提交消息,你的 PR 将会在三天内被自动关闭。

Generated with ❤️ by ElementPlusBot

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=9360
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented Aug 30, 2022

Thanks for your contribution

@tolking tolking merged commit d4d411c into element-plus:dev Aug 30, 2022
@element-bot element-bot mentioned this pull request Sep 2, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants