New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(icon): reduce getter access. #9360
Conversation
👋 @zhangenming, seems like this is your first time contribution to element-plus.
|
Hello @zhangenming, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
Hello, @, seems like your commit message contains some issues. 你好,@,你的提交消息不符合 Element Plus 的提交消息规范。
Please refer to Commit Example for fixing it. 请参考 提交示例 来修改你的提交消息。 Note that all your commits will be squashed into one for being linted, so you might need to revision your commits. 你的所有 commit(s) 会被合并为一个 commit 来被验证,所以你可能需要修改你之前的 commit(s) 消息。 If you find it hard to do it by yourself, run command below to use an intuitive tool for that. 如果你觉得自己写这个提交消息很难,请使用下面的命令来启动一个交互式工具来帮助你生成消息。 pnpm cz Note that if you do not fix the commit message issue, your PR will be automatically closed within 3 days. 请注意,如果你没有按照规范修改你的提交消息,你的 PR 将会在三天内被自动关闭。 Generated with ❤️ by ElementPlusBot |
🧪 Playground Preview: https://element-plus.run/?pr=9360 |
Thanks for your contribution |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.