Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [image-viewer] add setActiveItem method #9389

Merged
merged 5 commits into from Aug 26, 2022
Merged

feat(components): [image-viewer] add setActiveItem method #9389

merged 5 commits into from Aug 26, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Aug 19, 2022 •
edited

closes #9387

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Aug 19, 2022 •
edited

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@holazz holazz marked this pull request as draft August 19, 2022 10:36
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 19, 2022
@github-actions
Copy link

github-actions bot commented Aug 19, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9389
Please comment the example via this playground if needed.

@holazz holazz changed the title fix(components): [image-viewer] initialIndex lost reactivity feat(components): [image-viewer] add setActiveItem method Aug 20, 2022
@holazz holazz marked this pull request as ready for review August 20, 2022 03:41
@holazz holazz mentioned this pull request Aug 20, 2022
Closed
@faintout
Copy link

please merge commit

@btea btea merged commit e33a279 into element-plus:dev Aug 26, 2022
@holazz holazz deleted the fix/image-viewer_initialIndex branch August 26, 2022 10:56
@element-bot element-bot mentioned this pull request Sep 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [image-viewer] el-image-viewer 的initialIndex值不是动态的
4 participants
@holazz @faintout @btea @ryuhangyeong