Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [message-box] allow pass function to message option #9405

Merged
merged 3 commits into from
Sep 4, 2022
Merged

feat(components): [message-box] allow pass function to message option #9405

merged 3 commits into from
Sep 4, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Aug 22, 2022

Support pass a function that returns VNode to message option, fixes #9361

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@holazz holazz marked this pull request as draft August 22, 2022 11:21
@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9405
Please comment the example via this playground if needed.

@holazz holazz marked this pull request as ready for review August 22, 2022 11:39
@holazz holazz force-pushed the feat/message-box_message_function branch from 56422cf to e930100 Compare August 23, 2022 01:21
@xiaoxian521 xiaoxian521 self-requested a review September 3, 2022 15:33
@xiaoxian521
Copy link
Member

在文档添加一个例子更完美 ❤️

@holazz
Copy link
Member Author

holazz commented Sep 4, 2022 •
edited

在文档添加一个例子更完美 ❤️

已添加，并且修改了部分内容。

@xiaoxian521 xiaoxian521 requested a review from a team September 4, 2022 10:06
@xiaoxian521 xiaoxian521 merged commit 6eded0b into element-plus:dev Sep 4, 2022
@holazz holazz deleted the feat/message-box_message_function branch September 4, 2022 12:45
@element-bot element-bot mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holazz @xiaoxian521