Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [upload] onPreview not work when picture list type #9448

Merged
merged 3 commits into from Aug 27, 2022
Merged

fix(components): [upload] onPreview not work when picture list type #9448

merged 3 commits into from Aug 27, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Aug 25, 2022 •
edited by sxzz

closes #9437, #9452

Before:

before

After:

2022-08-25.9.48.33.mov

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@holazz holazz marked this pull request as draft August 25, 2022 01:45
@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9448
Please comment the example via this playground if needed.

@holazz holazz marked this pull request as ready for review August 25, 2022 03:09
@holazz holazz mentioned this pull request Aug 25, 2022
Closed
3 tasks
@sxzz sxzz enabled auto-merge (squash) August 27, 2022 16:23
@sxzz sxzz merged commit eed5763 into element-plus:dev Aug 27, 2022
@holazz holazz deleted the fix/upload_preview branch August 27, 2022 23:59
@holazz holazz mentioned this pull request Aug 28, 2022
Closed
@element-bot element-bot mentioned this pull request Sep 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [upload] el-Upload 使用 list-type="'picture'"时on-change的点击无法生效
2 participants
@holazz @sxzz