fix(components): [dialog] bind $attrs
#9455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @holazz, thank you for contributing element-plus.
|
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=9455 |
holazz
force-pushed
the
fix/dialog_attrs
branch
from
bb7d9b5
to
ef78e9b
Compare
sxzz
reviewed
Aug 27, 2022
holazz
force-pushed
the
fix/dialog_attrs
branch
from
0ba1231
to
1244ac9
Compare
|
@sxzz Updated. And I added a deprecated tag component to the docs, what do you think?
|
sxzz
approved these changes
Aug 29, 2022
holazz
force-pushed
the
fix/dialog_attrs
branch
from
1244ac9
to
89b06bc
Compare
sxzz
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9450
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.