Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] update finished calculating optionsInDropdown #9475

Merged
merged 1 commit into from Aug 31, 2022
Merged

fix(components): [select] update finished calculating optionsInDropdown #9475

merged 1 commit into from Aug 31, 2022

Conversation

Tsong-LC
Copy link
Contributor

closed #7507

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Tsong-LC, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @Tsong-LC, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited

@Tsong-LC
Copy link
Contributor Author

Tsong-LC commented Aug 26, 2022 •
edited

before example

after example

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 26, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=9475
Please comment the example via this playground if needed.

@xiaoxian521 xiaoxian521 self-requested a review August 31, 2022 05:35
@xiaoxian521 xiaoxian521 merged commit 6e3774f into element-plus:dev Aug 31, 2022
@Tsong-LC Tsong-LC deleted the fix/select branch September 1, 2022 05:52
@element-bot element-bot mentioned this pull request Sep 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

Assignees

@Tsong-LC Tsong-LC

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
2 participants
@Tsong-LC @xiaoxian521