Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [time-picker] add open and close handlers #9572

Merged
merged 7 commits into from Sep 1, 2022
Merged

feat(components): [time-picker] add open and close handlers #9572

merged 7 commits into from Sep 1, 2022

Conversation

jagoncalves14
Copy link
Contributor

Add new methods handleOpen and handleClose to ElTimePicker component, in order to be able to open/close them programmatically.

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @jagoncalves14, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited

@github-actions
Copy link

Hello @jagoncalves14, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@xiaoxian521
Copy link
Member

xiaoxian521 commented Sep 1, 2022 •
edited

Hey, thank you very much for your contribution, but here are some conflicts that need to be solved by you. We can continue to review the code after solving. One thing to remind is that if the conflicts is still not resolved after 10 days, sorry, we will close this pr ❤️

@xiaoxian521 xiaoxian521 added the conflict pending need to resolve conflicts label Sep 1, 2022
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9572
Please comment the example via this playground if needed.

@xiaoxian521 xiaoxian521 self-requested a review September 1, 2022 12:47
xiaoxian521
xiaoxian521 requested changes Sep 1, 2022
View reviewed changes
docs/en-US/component/time-picker.md Outdated Show resolved Hide resolved
docs/en-US/component/time-picker.md Outdated Show resolved Hide resolved
@xiaoxian521 xiaoxian521 removed the conflict pending need to resolve conflicts label Sep 1, 2022
@xiaoxian521 xiaoxian521 merged commit 8156606 into element-plus:dev Sep 1, 2022
@element-bot element-bot mentioned this pull request Sep 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

Assignees

@jagoncalves14 jagoncalves14

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jagoncalves14 @xiaoxian521