-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [popper] add missing id #9632
Conversation
👋 @plehnen, seems like this is your first time contribution to element-plus.
|
🧪 Playground Preview: https://element-plus.run/?pr=9632 |
9a8eb65
to
fa0f498
Compare
511e2d9
to
4f37187
Compare
I think a reasonable way to solve this issue is to add the condition that element-plus/packages/components/popper/src/content.vue Lines 232 to 236 in d215fee
if (isElement(prevEl) && prevEl !== el) {
// ...
} |
0716a37
to
e410431
Compare
@holazz Thanks! I've reverted the previous changes and added the condition you recommended. Branch is updated and changes are pushed. |
e410431
to
c40f2a7
Compare
c40f2a7
to
e224de6
Compare
the currenct popperjs version in element-plus removes the "id"-property. So the aria-describedby reference is pointing to something which doesn't exist in the DOM.
This issue applies for all places where popper is used, i.e. "select", "popover", "date-picker", ...
this fixes #9200 and fixes #8155