Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [time-picker] fix end-time can't be callback #9669

Merged
merged 6 commits into from
Sep 8, 2022
Merged

fix(components): [time-picker] fix end-time can't be callback #9669

merged 6 commits into from
Sep 8, 2022

Conversation

konata33
Copy link
Contributor

@konata33 konata33 commented Sep 6, 2022 •
edited

fix end-time can't be return callback

closed #9460

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@konata33
fix(components): [time-picker]
36d916a 
fix end-time can't be return callback

closed element-plus#9460
@pull-request-triage
Copy link

👋 @MrCat33, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Hello @MrCat33, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9669
Please comment the example via this playground if needed.

@sxzz
Copy link
Collaborator

sxzz commented Sep 6, 2022 •
edited

please fill in your PR title.

Update:

Also, it will make the unit tests fail... Please check your code

@konata33
fix(components): [time-picker]
876d758 
fix end-time can't be return callback

BREAKING CHANGE :
no

closed element-plus#9460
@konata33
Merge branch 'dev' into dev
824c9bb
@konata33 konata33 changed the title fix(components): [time-picker] fix(components): [time-picker] end-time can't be callback Sep 7, 2022
@konata33 konata33 changed the title fix(components): [time-picker] end-time can't be callback fix(components): [time-picker] fix end-time can't be callback Sep 7, 2022
@holazz
Copy link
Member

holazz commented Sep 8, 2022

What is your intention to modify the test cases? 🤔

@konata33
Copy link
Contributor Author

konata33 commented Sep 8, 2022

It should have a value or null at the handleFocusInput function, but the test cases only expect null

@holazz
Copy link
Member

holazz commented Sep 8, 2022

Thanks for your contribution ❤

@xiaoxian521 xiaoxian521 merged commit f6d4574 into element-plus:dev Sep 8, 2022
@holazz holazz mentioned this pull request Sep 11, 2022
Closed
@element-bot element-bot mentioned this pull request Sep 16, 2022
Merged
3 tasks
@ntnyq ntnyq mentioned this pull request Sep 27, 2022
Closed
This was referenced Sep 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

Assignees

@konata33 konata33

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
4 participants
@konata33 @sxzz @holazz @xiaoxian521