-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [select] fix option-group get wrong visible #9726
Conversation
👋 @init-qy, seems like this is your first time contribution to element-plus.
|
Please add the demo before and after the repair so that we can better review |
🧪 Playground Preview: https://element-plus.run/?pr=9726 |
nextTick looks like break a test case, so I add it, now it works |
Maybe use post flush watcher instead of nextTick? |
ok, it aslo works, I first learned about watcher Callback Flush Timing |
95056ea
to
30a8331
Compare
…-plus#9726) * fix(components): [select] fix option-group get wrong visible * fix(components): [select] fix option-group get wrong visible * fix(components): [select] fix option-group get wrong visible Co-authored-by: qinye <953218204@qq.com>
closed #9711
it can fix this problem, with nextTick I can get current children visible
but I don't know what was modified in vue3.2.38 cause this problem
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.