Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] fix option-group get wrong visible #9726

Merged
merged 3 commits into from
Sep 10, 2022

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Sep 9, 2022

closed #9711

it can fix this problem, with nextTick I can get current children visible
but I don't know what was modified in vue3.2.38 cause this problem

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @init-qy, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

@xiaoxian521
Copy link
Member

Please add the demo before and after the repair so that we can better review

@xiaoxian521 xiaoxian521 self-requested a review September 9, 2022 11:30
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

🧪 Playground Preview: https://element-plus.run/?pr=9726
Please comment the example via this playground if needed.

@init-qy
Copy link
Contributor Author

init-qy commented Sep 9, 2022

playground

@init-qy
Copy link
Contributor Author

init-qy commented Sep 9, 2022

nextTick looks like break a test case, so I add it, now it works

@holazz holazz self-requested a review September 9, 2022 14:23
@holazz
Copy link
Member

holazz commented Sep 10, 2022

Maybe use post flush watcher instead of nextTick?

@init-qy
Copy link
Contributor Author

init-qy commented Sep 10, 2022

Maybe use post flush watcher instead of nextTick?

ok, it aslo works, I first learned about watcher Callback Flush Timing
later I will change it

@xiaoxian521 xiaoxian521 merged commit c64ea61 into element-plus:dev Sep 10, 2022
konata33 pushed a commit to konata33/element-plus that referenced this pull request Sep 14, 2022
…-plus#9726)

* fix(components): [select] fix option-group get wrong visible

* fix(components): [select] fix option-group get wrong visible

* fix(components): [select] fix option-group get wrong visible

Co-authored-by: qinye <953218204@qq.com>
@element-bot element-bot mentioned this pull request Sep 16, 2022
3 tasks
@init-qy init-qy deleted the fix/option-group branch October 4, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [select] select分组筛选问题
3 participants