Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [checkbox] wrong checked status when label is Object #9863

Merged
merged 3 commits into from
Nov 10, 2022
Merged

fix(components): [checkbox] wrong checked status when label is Object #9863

merged 3 commits into from
Nov 10, 2022

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Sep 22, 2022 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

closed #9855, closed #10090

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @init-qy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited

@github-actions
Copy link

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=9863
Please comment the example via this playground if needed.

@init-qy init-qy changed the title Fix/checkbox fix(components): [checkbox] wrong checked status when label is Object Sep 22, 2022
@init-qy
Copy link
Contributor Author

init-qy commented Sep 22, 2022

playground

@tolking tolking requested a review from chenxch November 8, 2022 16:31
@chenxch
Copy link
Member

chenxch commented Nov 9, 2022

Received, I will confirm it later.

@tolking tolking merged commit 4b0db5d into element-plus:dev Nov 10, 2022
@element-bot element-bot mentioned this pull request Nov 11, 2022
Merged
3 tasks
@init-qy init-qy deleted the fix/checkbox branch May 10, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@tolking tolking tolking approved these changes

Assignees

@init-qy init-qy

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@init-qy @chenxch @tolking