Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to "Fixes k8s restore pvc" #107

Merged
merged 9 commits into from
Mar 3, 2021
Merged

Conversation

elemental-lf
Copy link
Owner

This PR does some refactoring so that common code can be shared in addition to the changes in #104.

@elemental-lf elemental-lf force-pushed the jasonb5-fix_restore branch 6 times, most recently from 525293a to 67224f9 Compare February 17, 2021 17:17
@elemental-lf
Copy link
Owner Author

There's a container image if anyone wants to test this: ghcr.io/elemental-lf/benji-k8s:jasonb5-fix_restore.
@jasonb5 I rewrote your --ios-name option to be more flexible (could now pass in other Ceph options too) and renamed it because of that. I'm still not happy with how the refactoring turned it. This needs at least another iteration.

@elemental-lf elemental-lf merged commit 6e27a2a into master Mar 3, 2021
@jasonb5
Copy link
Contributor

jasonb5 commented Mar 30, 2021

@elemental-lf Thank you so much for all this great work! Apologies for the tardiness of this, work had me side tracked for some time. I've since then updated to 0.14.1 and everything works great! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants