allow us to not delete files #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiob
requested changes
Sep 4, 2020
watch
Outdated
| echo "backup failed" 1>&2 | ||
| return 1 | ||
| fi | ||
| } | ||
|
|
||
| function final_backup { | ||
| echo "backup $LOCAL => $REMOTE" | ||
| while ! $AWS s3 sync "$LOCAL" "$REMOTE" --delete; do | ||
| while ! $AWS s3 sync "$LOCAL" "$REMOTE" $DELETE_FLAG; do |
There was a problem hiding this comment.
I think S3_SYNC_FLAGS is a better name.
Draft
mirsal
reviewed
Dec 2, 2020
Co-authored-by: Mirsal <mirsal@mirsal.fr>
fabiob
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was surprising for some devs on our team to have the remote files deleted when they cleaned up locally and I figured it wouldn't hurt to give the option to turn it off.