Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that unicode such as 馃槺 work for dbt args #1312

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Ensure that unicode such as 馃槺 work for dbt args #1312

merged 1 commit into from
Dec 4, 2023

Conversation

erikzaadi
Copy link
Contributor

Emoji's should be ok to be a part of json strings used for dbt args

@linear Linear
Copy link

linear bot commented Dec 4, 2023

ELE-2109 dbt run args should not fail if they contain unicode

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

馃憢 @erikzaadi
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@erikzaadi erikzaadi force-pushed the ele-2109-dbt-run-args-should-not-fail-if-they-contain-unicode branch from bd84379 to 16bafb6 Compare December 4, 2023 12:59
NoyaArie
NoyaArie approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@NoyaArie NoyaArie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikzaadi erikzaadi force-pushed the ele-2109-dbt-run-args-should-not-fail-if-they-contain-unicode branch from 16bafb6 to 57103bd Compare December 4, 2023 13:21
@erikzaadi erikzaadi merged commit 57103bd into master Dec 4, 2023
3 checks passed
@erikzaadi erikzaadi deleted the ele-2109-dbt-run-args-should-not-fail-if-they-contain-unicode branch December 4, 2023 13:42
@philk1991 philk1991 mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elongl elongl elongl approved these changes

@NoyaArie NoyaArie NoyaArie approved these changes

@ofek1weiss ofek1weiss ofek1weiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erikzaadi @elongl @NoyaArie @ofek1weiss