ELE-2617 - Fix disable samples for alerts #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @IDoneShaveIt |
ellakz
reviewed
Mar 4, 2024
| @@ -183,6 +185,9 @@ def format_alert( | |||
| elementary_database_and_schema: Optional[str] = None, | |||
| global_suppression_interval: int = 0, | |||
| override_config: bool = False, | |||
| disable_samples: bool = False, | |||
| *args, | |||
There was a problem hiding this comment.
why do you need those? it's better to be explicit about what args and kwargs can be passed on
There was a problem hiding this comment.
The function that is using the format_alert method is calling it for 3 different type of alerts.
Each alert has different arguments for the format_alert method.
That way we can assure that each format_alert define only the arguments it needed, and not fail when we pass it extra arguments.
This is (as I see it) a valid use of args and kwargs 🙂
IDoneShaveIt
deleted the
ele-2617-disable-samples-at-edr-monitor-does-not-work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we disable the alerts samples when the flag --disable-samples is True