Ele 2626 support singular tests in test results runs #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @NoyaArie |
NoyaArie
commented
Mar 6, 2024
| @@ -20,8 +20,8 @@ | |||
| class FiltersAPI(APIClient): | |||
| def get_filters( | |||
| self, | |||
| test_results_totals: Dict[Optional[str], TotalsSchema], | |||
There was a problem hiding this comment.
keys of test_results, test_runs, test_results_totals, test_runs_totals are no longer nullable
NoyaArie
commented
Mar 6, 2024
| @@ -67,14 +67,14 @@ def get_report_data( | |||
| models = models_api.get_models(exclude_elementary_models) | |||
| sources = models_api.get_sources() | |||
| exposures = models_api.get_exposures() | |||
| tests = tests_api.get_singular_tests() | |||
NoyaArie
commented
Mar 6, 2024
| @@ -140,9 +140,11 @@ def get_report_data( | |||
|
|
|||
| invocations_job_identification = defaultdict(list) | |||
| for invocation in invocations: | |||
| key = invocation.job_name or invocation.job_id | |||
There was a problem hiding this comment.
rename key to invocation_key
erikzaadi
approved these changes
Mar 6, 2024
NoyaArie
force-pushed
the
ele-2626-support-singular-tests-in-test-results-runs
branch
from
13ec388
to
e52b704
Compare
NoyaArie
deleted the
ele-2626-support-singular-tests-in-test-results-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.