Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELE-2933: Column anomalies group_by - CLI #1499

Merged
merged 9 commits into from
May 2, 2024
Merged

ELE-2933: Column anomalies group_by - CLI #1499

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
63d9929
return columns with dimensions
dapollak Apr 24, 2024
7990418
fix display name
dapollak Apr 24, 2024
0e09218
add is_anomalous check
dapollak Apr 24, 2024
3d059a0
headers
dapollak Apr 24, 2024
0a703a5
remove log
dapollak Apr 24, 2024
adc70e1
change parameter name
dapollak Apr 30, 2024
1684616
Merge branch 'master' into ele-2933-cli-ui
dapollak Apr 30, 2024
990c514
fix condition
dapollak Apr 30, 2024
c784574
Merge branch 'master' into ele-2933-cli-ui
dapollak May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions elementary/monitor/dbt_project/macros/get_test_results.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
{% set test_rows_sample = none %}
{% if test.invocations_rank_index == 1 %}
{% set test_type = test.test_type %}
{% set test_params = fromjson(test.test_params) %}
{% set status = test.status | lower %}

{% set elementary_tests_allowlist_status = ['fail', 'warn'] %}
Expand All @@ -70,14 +71,19 @@
{% set test_rows_sample = elementary_cli.get_test_rows_sample(test.result_rows, test_result_rows_agate.get(test.id)) %}
{# Dimension anomalies return multiple dimensions for the test rows sample, and needs to be handle differently. #}
{# Currently we show only the anomalous for all of the dimensions. #}
{% if test.test_sub_type == 'dimension' %}
{% if test.test_sub_type == 'dimension' or test_params.dimensions %}
{% if test.test_sub_type == 'dimension' %}
{% set metric_name = 'row_count' %}
{% elif test_params.dimensions %}
{% set metric_name = test.test_sub_type %}
{% endif %}
{% set anomalous_rows = [] %}
{% set headers = [{'id': 'anomalous_value_timestamp', 'display_name': 'timestamp', 'type': 'date'}] %}
{% for row in test_rows_sample %}
{% set anomalous_row = {
'anomalous_value_timestamp': row['end_time'],
'anomalous_value_row_count': row['value'],
'anomalous_value_average_row_count': row['average'] | round(1)
'anomalous_value_timestamp': row['end_time'],
'anomalous_value_' ~ metric_name: row['value'],
'anomalous_value_average_' ~ metric_name: row['average'] | round(1)
} %}
{% set dimensions = row['dimension'].split('; ') %}
{% set diemsions_values = row['dimension_value'].split('; ') %}
Expand All @@ -90,12 +96,14 @@
{% do headers.append({'id': dimensions[index], 'display_name': dimensions[index], 'type': 'str'},) %}
{% endfor %}
{% endif %}
{% do anomalous_rows.append(anomalous_row) %}
{% if row['is_anomalous'] %}
{% do anomalous_rows.append(anomalous_row) %}
{% endif %}
{% endfor %}
{# Adding the rest of the static headers (metrics headers) #}
{% do headers.extend([
{'id': 'anomalous_value_row_count', 'display_name': 'row count', 'type': 'int'},
{'id': 'anomalous_value_average_row_count', 'display_name': 'average row count', 'type': 'int'}
{'id': 'anomalous_value_' ~ metric_name, 'display_name': ' '.join(metric_name.split('_')), 'type': 'int'},
{'id': 'anomalous_value_average_' ~ metric_name, 'display_name': 'average ' ~ ' '.join(metric_name.split('_')), 'type': 'int'}
]) %}
{% set test_rows_sample = {
'headers': headers,
Expand Down
Loading