Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databricks support #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjrulesamrat
Copy link

No description provided.

@mjrulesamrat
Copy link
Author

Please review and suggest edits! I'm willing to work on this PR to provide databricks support.

Copy link
Member

@elongl elongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to elaborate on where does this change meet you?
Thanks.

@@ -32,3 +32,8 @@
{% set database = target.project %}
{{ return(database) }}
{% endmacro %}

{% macro databricks__target_database() %}
{% set database = target.schema %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think host is more closely related to database.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've implemented it like this on the dbt package.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elongl for the response.

Does that mean we have to open PR on elementary-data/dbt-data-reliability repository as well to complement changes in elementary-action repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants