Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.github.jeysonflores.hasher 1.0.2 #95

Merged
merged 7 commits into from Aug 27, 2021

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented Aug 24, 2021

Review Checklist

  • 1.0.1-5 release data missing JeysonFlores/hasher#10
  • App opens
  • Does what it says
  • Matches description in AppData
  • Matches screenshot
  • AppData custom colors are contrasty
  • Name is unique and non-confusing
  • Uses elementary Flatpak runtime
  • Sandbox permissions are reasonable

@JeysonFlores
Copy link
Contributor

Fixed on #11 . New release done (1.0.1-6).

@cassidyjames cassidyjames changed the title com.github.jeysonflores.hasher 1.0.1-5 com.github.jeysonflores.hasher 1.0.1-6 Aug 24, 2021
@cassidyjames cassidyjames marked this pull request as ready for review August 24, 2021 22:26
@cassidyjames cassidyjames requested a review from a team August 24, 2021 22:26
@JeysonFlores
Copy link
Contributor

Oh, I didn't close the tags properly on the AppData file

@danirabbit
Copy link
Member

@JeysonFlores it looks like this release fails to build because of invalid appdata.xml. It's probably worth cleaning up the indentation there a bit so that it's easier to make sure xml tags are closed

@JeysonFlores
Copy link
Contributor

Yeah, this release should work now (1.0.1-7)

@JeysonFlores
Copy link
Contributor

Hey guys, I kept working on Hasher since yesterday and I added some new features and improvements to it, like adding translation support and multithreading hashing, so I made a new release. The current version is the 1.0.2 . Please check it out!

@danirabbit danirabbit changed the title com.github.jeysonflores.hasher 1.0.1-6 com.github.jeysonflores.hasher 1.0.2 Aug 26, 2021
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice update!

@danirabbit danirabbit merged commit ec563d4 into main Aug 27, 2021
@danirabbit danirabbit deleted the com.github.jeysonflores.hasher-1.0.1-5 branch August 27, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants