Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly wide origin combobox causes layout issues #1416

Closed
2 of 3 tasks
mcclurgm opened this issue Sep 27, 2020 · 0 comments · Fixed by #1417
Closed
2 of 3 tasks

Overly wide origin combobox causes layout issues #1416

mcclurgm opened this issue Sep 27, 2020 · 0 comments · Fixed by #1417

Comments

@mcclurgm
Copy link
Sponsor

Prerequisites

  • I have searched open and closed issues for duplicates.

Describe the bug

If the ComboBox for origin selection is overly long, it can cause other widgets to be laid out incorrectly. It makes its column take up too much space, so other things can't take the width they need. Here's an example photo:
long-origin
The "Abbrechen" button is supposed to be inside the column boundaries, which you can see overlap it.
The AppCenter label is wrong (already fixed in git, I hear), but it exposes a potential issue here. I enabled layout bounds to show the dimensions of the widgets. This shows that the progress bar is being pushed to the right by the labels, which are overly long because they match the size of the ComboBox.

Possible Solution

I think I've come up with a solution, but since this requires newer libraries than I have on Hera, I can't test it. Here's what I think we should do:
In AppInfoView.vala line 319, change:

-            header_grid.attach (origin_combo_revealer, 1, 2);
+            header_grid.attach (origin_combo_revealer, 1, 2, 2);

This makes it take up multiple columns. Since there's nothing else in its row, this shouldn't be an issue.

I'd like to submit a PR myself, but I don't feel like I can without knowing whether the code works. Hopefully this is enough info to make one easy for someone else.

Platform Information

about

  • I'm using the latest version from git that I've manually compiled
  • I'm using the latest released stable version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant