Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appcenter fails to compile on fedora 34+ (probably caused by appstream 0.13) #1479

Closed
decathorpe opened this issue Jan 18, 2021 · 1 comment

Comments

@decathorpe
Copy link
Contributor

appcenter from the master branch fails to compile on fedora 34 since about a month ago. I am unsure whether this issue was caused by a Vala or libappstream update, but it looks like one of the types is no longer compatible (weak vs. non-weak AppStream.Components in the array). However, I think that appstream 0.13.1 might be the cause. The last good build of appcenter was still with appstream 0.12.11.

../src/Core/FlatpakBackend.vala:289.53-289.57: error: Assignment: Cannot convert from `GLib.GenericArray<AppStream.Component>' to `GLib.GenericArray<weak AppStream.Component>?'
        GLib.GenericArray<weak AppStream.Component> comps = user_appstream_pool.search (query);
                                                    ^^^^^
../src/Core/PackageKitBackend.vala:396.53-396.57: error: Assignment: Cannot convert from `GLib.GenericArray<AppStream.Component>' to `GLib.GenericArray<weak AppStream.Component>?'
        GLib.GenericArray<weak AppStream.Component> comps = appstream_pool.search (query);
                                                    ^^^^^
../src/Views/AbstractView.vala:34.55-34.93: warning: Access to possible `null'. Perform a check or use an unsafe cast.
                    if (child is Views.AppInfoView && (child as Views.AppInfoView).to_recycle) {
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 1 warning(s)

Relevant package versions:

  • appstream 0.13.1
  • vala 0.48.13
  • meson 0.56.0
  • gcc 11 pre-release
@cassidyjames cassidyjames added this to ToDo in Distro-agnostic Pantheon via automation Feb 10, 2021
@decathorpe
Copy link
Contributor Author

Fixed by PR #1493 , thanks!

Distro-agnostic Pantheon automation moved this from ToDo to Done Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant