Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is disabled from within app details page #743

Closed
alex285 opened this issue Jul 18, 2018 · 2 comments
Closed

Search is disabled from within app details page #743

alex285 opened this issue Jul 18, 2018 · 2 comments
Labels
Status: Design Conflict Not going to be addressed due to a conflict with the HIG or other design considerations Status: Duplicate Already reported elsewhere

Comments

@alex285
Copy link

alex285 commented Jul 18, 2018

Reproduce

1. Open AppCenter

search1

The focus in on Search Input that is empty, and we can search for apps

2. Get inside an app

search2

When we get inside an app the search input says "Search Apps" but it is actually disabled. To search again we need to go back to the frontpage or search page if we performed a search before

I think we should be able to make a new search from inside an app details page, or at least search entry hasn't much point to be there if disabled

Perhaps a bit related to #554

@cassidyjames
Copy link
Contributor

This is intentional, and a duplicate of #705. The problem, as stated in the other issue, is that the context of this search would be unclear and seemingly nondeterministic in this view, depending on how you arrived at the app listing. I'm open to reconsidering, but I don't think dropping back to a global app search would be appropriate when on all other views it searches the current view.

@cassidyjames cassidyjames added Status: Design Conflict Not going to be addressed due to a conflict with the HIG or other design considerations Status: Duplicate Already reported elsewhere labels Jul 18, 2018
@alex285
Copy link
Author

alex285 commented Jul 18, 2018

Hello @cassidyjames

Suppose someone is on front page and performs a search. Then he gets inside a result in AppDetails page. It is most probable to not want to perform a second search from there, but to go back and check out another result

My point is that from "usability" side that issue might not be that terrible. But from design side it feels "wrong" to see a search disabled. Also the "context" of the search looks like "global" so it isn't confusing or unclear

Moreover if you (as project) don't want to have a search there, why don't you remove the whole entry from AppDetails?

Btw Windows 10 Store search that is similar, has a drop down menu as you type, with 4-5 apps. That could play nicely when inside AppDetails page

Same happens on Switchboard (elementary/switchboard#72). Again someone constantly sees a disabled search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Design Conflict Not going to be addressed due to a conflict with the HIG or other design considerations Status: Duplicate Already reported elsewhere
Projects
None yet
Development

No branches or pull requests

2 participants