New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemon: Use GLib.Notification #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to refactor Daemon.vala as a GLib.Application. Also, for me, the daemon does not work properly unless it is installed in /usr/bin rather than /usr/libexec (not sure why yet)
daemon/Daemon.vala
Outdated
warning ("Could not show notification: %s", err.message); | ||
} | ||
#endif | ||
GLib.Application.get_default ().send_notification (uid, notification); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work because Daemon.vala is not a GLib.Application (at the moment).
Ignore comment about libexec. Binaries here are not expected to be in the user's path (so I had trouble launching it from the terminal for testing). The daemon should be installed here. |
Fixes #17