Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with libecal-1.2 and libical-glib #431

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

tintou
Copy link
Member

@tintou tintou commented Sep 13, 2019

This looks minimal thanks to the previous PRs.
Fixes #404

@decathorpe
Copy link
Contributor

I'm getting some CRITICAL level errors in the logs, but this seems to work fine. Creating and deleting events works, even with locations attached to them. Tested on fedora 31 beta.

(io.elementary.calendar:3278): libical-glib-CRITICAL **: 12:57:58.552: i_cal_geo_get_lat: assertion 'geo != NULL' failed

(io.elementary.calendar:3278): libical-glib-CRITICAL **: 12:57:58.552: i_cal_geo_get_lon: assertion 'geo != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:57:58.557: maya_services_event_parser_handler_get_parser: assertion 'lang != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:57:58.557: maya_services_event_parser_get_language: assertion 'self != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:57:58.557: string_contains: assertion 'self != NULL' failed

(io.elementary.calendar:3278): Gdk-WARNING **: 12:58:01.036: Native Windows taller than 65535 pixels are not supported

(io.elementary.calendar:3278): Gtk-CRITICAL **: 12:58:45.781: gtk_text_buffer_set_text: assertion 'text != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:45.790: maya_services_event_parser_handler_get_parser: assertion 'lang != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:45.790: maya_services_event_parser_get_language: assertion 'self != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:45.790: string_contains: assertion 'self != NULL' failed

(io.elementary.calendar:3278): Gtk-CRITICAL **: 12:58:54.034: gtk_text_buffer_set_text: assertion 'text != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:54.042: maya_services_event_parser_handler_get_parser: assertion 'lang != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:54.042: maya_services_event_parser_get_language: assertion 'self != NULL' failed

** (io.elementary.calendar:3278): CRITICAL **: 12:58:54.042: string_contains: assertion 'self != NULL' failed

@hedning hedning mentioned this pull request Sep 17, 2019
20 tasks
@danirabbit danirabbit merged commit 46346e4 into master Sep 17, 2019
@danirabbit danirabbit deleted the tintou/eds-3-24 branch September 17, 2019 18:16
@worldofpeace
Copy link
Contributor

Thanks for the prompt integration ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port to libecal-2.0
4 participants