Send notification when recording has finished.

[igordsm]

Closes #113 .

This is very open for comments. I had never used notifications and actions before, so this may not be the best or even correct way of doing this. If this is indeed garbage, I would appreciate some pointers on how to do this right.

Best regards,

[cassidyjames]

Thanks for working on this @igordsm! I left a comment on the original issue; as a note, it can be helpful to make sure an issue is confirmed and has input from @elementary/ux before jumping into implementation. That said, if this could be changed to a toast, I think it could be useful.

See: #113 (comment)

[igordsm]

@cassidyjames Thank you the input on #113 . I have updated the code to reflect the new design using Toast. Feel free to comment when you have the time.

[jeremypw]

This works fine if the video is saved OK. My only quibble is that there is no checking of the path returned and it could in theory be "", in which a different message should be displayed.

[davidmhewitt]

I've noticed that this doesn't highlight the relevant file in the folder. It is possible to do this by getting the AppInfo of the file manager and then telling it to open the URI of the file. Or there is the ShowItems method on the org.freedesktop.FileManager1 interface.

However, we could follow up with that later.

[igordsm]

@jeremypw If location is empty it now shows the following toast:

@davidmhewitt I'm now using GLib.File.get_parent () to get the folder path. I suppose that's what you were suggesting earlier. Am I correct? I also tried to get the AppInfo for the file manager (using AppInfo.get_default_for_uri (..)) , but keep getting null as result. Any tips?

[jeremypw]

Works as expected. I think, overall it is clearer to use a second toast, as you have done, than try to modify one toast according the outcome.

[jeremypw]

Leaving open as there is an outstanding question for @davidmhewitt

[jeremypw]

This seems to work OK for me now. Adding the AppLaunchContext seems to fix the problem that if Files is already open on another workspace then nothing seems to happen. Now Gala switches workspace to the one that Files is on.

[jeremypw]

Not sure how FlatPaking this will affect the functionality though.