Port to HdyTabBar #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
requested changes
Sep 10, 2023
| cookie_manager.set_accept_policy (WebKit.CookieAcceptPolicy.ALWAYS); | ||
| cookie_manager.set_persistent_storage (cookies_db_path, WebKit.CookiePersistentStorage.SQLITE); | ||
| } else { | ||
| critical ("No cookies store found, not saving the cookies…"); |
There was a problem hiding this comment.
Is this being a critical now intentional?
There was a problem hiding this comment.
Yeah, I don't think this does anything anymore since we started to ship Epiphany in Flatpak, so I think it's good for it to make noise so we don't forget that it's broken 😅 I'm not sure if the ultimate solution is to remove this or what but I can revert that if you'd like :)
Co-authored-by: Leonhard <106322251+leolost2605@users.noreply.github.com>
|
Awesome thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.