Fix compile warnings #1056
Merged
Fix compile warnings #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with Vala/ I imagine it'll be a while before there's a version of Vte in the repos that contains a fixed vapi, but there will be one eventually, so it's probably better to not carry our own vapi here and just keep using the deprecated method for now. It still works after all. You could always leave a comment above the line that's giving the warnings saying we're waiting on a fixed vapi. |
danirabbit
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to stop the warning about the deprecated function
spawn_sync ()it was necessary to include a hacked version of thevte-2.91.vapias the one generated by GIR is incorrect. Whether it worth doing this is questionable.