-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sidebar pane the toplevel container #1218
Conversation
@danirabbit Please could you fix conflicts, thanks. |
@jeremypw done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I have with this design is that the close window button is no longer visually separated from the sidebar so it looks like a "close sidebar" button. Not sure what the solution is to this (if one is needed) and it is not blocking for me.
Code looks good.
The function of the project chooser button probably needs review. It always reverts to the project related to the focused document regardless of what selection is attempted. However, that is for another PR.
Closes #1217
Fits the more modern design we've been moving towards with other apps: