Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add duplicate project #1238

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Do not add duplicate project #1238

merged 2 commits into from
Jan 14, 2023

Conversation

jeremypw
Copy link
Collaborator

Fixes #1141

@jeremypw jeremypw added the Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Jan 14, 2023
@jeremypw jeremypw requested a review from a team January 14, 2023 18:54
danirabbit
danirabbit approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to reproduce the original issue, but this change makes sense 👍

@danirabbit danirabbit merged commit cdc1c60 into master Jan 14, 2023
@danirabbit danirabbit deleted the fix-duplicate-projects branch January 14, 2023 19:18
@jeremypw
Copy link
Collaborator Author

I still could reproduce it when dragging a tab to produce a new window, at least. The problematic code was still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project list contains duplicates after creating new window
2 participants
@jeremypw @danirabbit