Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always restore tabs when settings allow, save tabs from last window closed. #2272

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 30, 2023

Fixes #2235.

Following feedback from other PRs, this PR leaves restoring and saving tabs to the settings only, except that only the first window restores tabs.

  • Files opened from another app adds the requested tab to the active window, or opens a window with restored tabs if no active window and settings allow.
  • Every window saves its tabs, if settings allow, so the tabs from the last one closed only persist.

Tabs are restored if:

  • The window is the first opened window and
  • The Files "restore-tabs" settings is true and
  • The System "remember-history" setting is true and
  • The window was not opened as administrator

Tabs are saved if:

  • The Files "restore-tabs" settings is true and
  • The System "remember-history" setting is true and
  • The window was not opened as administrator

As a consequence of this PR it is no longer possible to open a window that does not save its tabs except by changing one of the above settings.

A further PR that exposes the "restore-tabs" setting in the AppMenu will be proposed to compensate for this.

@jeremypw jeremypw marked this pull request as ready for review July 30, 2023 14:50
@jeremypw jeremypw requested a review from Marukesu July 30, 2023 14:50
@jeremypw jeremypw merged commit 0207650 into main Jul 31, 2023
4 checks passed
@jeremypw jeremypw deleted the filemanager1-restoresave2 branch July 31, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening from another apps remove the tabs history
2 participants