DnD: Don't disable reactivity (#1610)

elementary · Apr 4, 2023 · 530a66e · 530a66e
1 parent c0a77ad
commit 530a66e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/data/gala.appdata.xml.in b/data/gala.appdata.xml.in
@@ -34,6 +34,7 @@
         <issue url="https://github.com/elementary/gala/issues/1566">Hotkeys are not working with non-EN keyboard layout</issue>
         <issue url="https://github.com/elementary/gala/issues/1578">Closing a window in multitasking view closes multitasking view</issue>
         <issue url="https://github.com/elementary/gala/issues/1584">When 2 windows are tiled and then resized, the inactive one gets glitched, leaving its full-sized picture as an artifact when minimized</issue>
+        <issue url="https://github.com/elementary/gala/issues/1607">Picture-in-Picture drag seems to snap to a grid</issue>
       </issues>
     </release>
 

diff --git a/lib/DragDropAction.vala b/lib/DragDropAction.vala
@@ -304,8 +304,6 @@ namespace Gala {
                             ungrab_actor ();
                             grab_actor (handle, event.get_device ());
 
-                            handle.reactive = false;
-
                             var source_list = sources.@get (drag_id);
                             if (source_list != null) {
                                 var dest_list = destinations[drag_id];

diff --git a/src/Widgets/IconGroup.vala b/src/Widgets/IconGroup.vala
@@ -520,6 +520,9 @@ namespace Gala {
 
             toggle_close_button (false);
 
+            // disable reactivity so that workspace thumbs can get events
+            reactive = false;
+
             return this;
         }