Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play login sound #1376

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Play login sound #1376

wants to merge 7 commits into from

Conversation

meisenzahl
Copy link
Member

Copy link
Member

@JoseExposito JoseExposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! One question: since the sound is being played on the workspace manager, wouldn't it be played if Gala crashes and is relaunched?

@meisenzahl
Copy link
Member Author

@JoseExposito yes if Gala would crash, the sound would be played again.

Do you have any idea how to prevent this?

@JoseExposito
Copy link
Member

Maybe you could use org.gnome.SessionManager to handle this case? I'm not sure if there is a signal/method you can use there. Gala already has a SessionManager class, so part of the job should be already done.

@JoseExposito
Copy link
Member

Code looks good, thanks!!! Handing over to the @elementary/ux team for their input.

Personal opinion: I'm am not a big fan of login sounds, so I'll be happy if this was something configurable in settings.

@cassidyjames
Copy link
Contributor

Yeah, I don't think a login sound is desirable by default. I could see the argument for a "ready" sound from an accessibility standpoint, but then it would need to be short and subtle enough to not be annoying every time you turn on your computer. We would also likely want a similar sound on the login screen to signal that's available for typing a password. Regardless, I think that would be off by default?

@meisenzahl
Copy link
Member Author

@elementary/ux is there any interest in adding optional system sounds?

@SubhadeepJasu
Copy link

Regarding the exact sounds, just posting them from here:
elementary/sound-theme#16
elementary/triage#98
Let me know if these are okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants