Fix awkward two-finger scroll in multitasking view #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easing wasn't being correctly used when scrolling between workspaces with the touchpad in the multitasking view. There were two problems with this: scrolling seemed to lag behind the user's fingers sometimes, and letting go of the touchpad would almost always cause a jarring jump. This little patch fixes both of these issues, making everything silky smooth.
lenemter
reviewed
Dec 21, 2022
|
Probably not. I created the method thinking I'd have to reset more state, but it turns out that one line was sufficient. |
|
Thanks :) Only got a couple things left to fix here, and then Gala will be practically perfect for me! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easing wasn't being correctly used when scrolling between workspaces with the touchpad in the multitasking view. There were two problems with this: scrolling seemed to lag behind the user's fingers sometimes, and letting go of the touchpad would almost always cause a jarring jump.
This little patch fixes both of these issues, making everything silky smooth.
If someone's not clear on what specifically we're solving here, I could record my screen and my hand on my touchpad before & after this patch. It really is night and day.