Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowClone: Fix shadows #1503

Merged
merged 6 commits into from Jan 15, 2023
Merged

WindowClone: Fix shadows #1503

merged 6 commits into from Jan 15, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Dec 26, 2022 •
edited

Fixes #1203

Before:

Screenshot from 2022-12-26 17 15 04

After:

Screenshot from 2022-12-26 17 14 41

Remove unused window_spread property.
Introduce a new window-clone css class with border-radius: 0; corners for WindowClone
Reuse values from get_bounding_box in modify_paint_volume

@lenemter lenemter requested a review from a team December 26, 2022 08:23
@lenemter
Copy link
Member Author

No shadows seem to use the default .decoration shadow, so maybe it would be better to make .window-clone.decoration the default .decoration style?

@zeebok zeebok merged commit 223fdb0 into master Jan 15, 2023
@zeebok zeebok deleted the fix-shadows branch January 15, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Artifact around non native apps in the overview mode
2 participants
@lenemter @zeebok