Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multitasking view animations #1529

Merged
merged 12 commits into from Feb 18, 2023
Merged

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Feb 6, 2023

  • Fix weird icon animation when opening multitasking view
  • Animate maximized windows' shadow opacity with gestures

@lenemter lenemter requested a review from a team February 6, 2023 02:54
@peteruithoven
Copy link
Collaborator

Could you clarify which shadow opacity animation you're referring to?

@lenemter
Copy link
Member Author

lenemter commented Feb 18, 2023

@peteruithoven This PR animates maximized windows shadow opacity when opening multitasking view with gestures. In master when opening/closing multitasking view with gestures shadow suddenly appears/disappears when you end the gesture.

@peteruithoven
Copy link
Collaborator

I think I might have captured that shadow issue in the following capture?
Gala master shadow issue.webm

@lenemter
Copy link
Member Author

@peteruithoven No, that is different bug that has been fixed in #1531. There is an update planned forward the end of February, so you need to wait for the fix :)

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@danirabbit danirabbit merged commit 1ca12ac into master Feb 18, 2023
@danirabbit danirabbit deleted the multitasking-view-fix-animations branch February 18, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants